Akiban Driver Implementation that Uses PDO #191
Conversation
…all methods are implemented yet.
…nterface. Nearly all methods still need to be implemented.
…o be implemented.
… and schema manager implementations.
…on. This is due to Akiban having a NOW() function that is compatible with MySQL.
…even if it contains tables.
…ception when that function is called.
…hat in platform implementation.
… doctrine coding standards.
|
Just wanted to check in because I will be away for a week and see if there any comments on this pull request that I should address before I leave? |
|
@posulliv the priority right now is to manage the release of 2.3. There is no hurry to merge it as Doctrine 2.4 is due in 6 months :) |
|
Sounds good to me! Thanks for the update :) |
|
@posulliv What's the status of this PR? Is the implementation finished? First off you need to rebase this PR against master, as it is not mergeable anymore. |
|
@posulliv Please provide this driver as a seperate package. |
|
There is a new version of this branch for FoundationDB SQL Layer, which is the new name of Akiban Server. It is all synced with master and up-to-date with product enhancements on our side. There are two challenges to releasing this as a separate package as suggested here.
Do you have recommendations for how we can meet your desire to keep the number of systems supported in the core manageable without making our addition seem second-class? |
Based on discussion in pull request 188 with @stof, I decided to modify the implementation for Akiban to use the PostgreSQL PDO driver instead of the native PHP client for PostgreSQL.
One piece of functionality that does not work with current version of Akiban is lastInsertId. This is because the implementation of CURRVAL for Akiban requires both schema name and sequence name be provided whereas PostgreSQL only requires sequence name (relevant source). I will attempt to get CURRVAL in Akiban implemented to have the same parameters as PostgreSQL.
This causes a few tests to fail in the test suite right now. Is there a way to mark a test as expected to fail for a specific database driver with the test suite? What I did in this pull request is skip any tests that use lastInsertId when testing against the Akiban platform. I'll update these tests to not be skipped when CURRVAL works as expected. Let me know if there is a better way to do that.